[clang] [Clang] Resolve FIXME: Use class method when receiver is reference to class (PR #85316)
via cfe-commits
cfe-commits at lists.llvm.org
Wed May 22 15:08:59 PDT 2024
https://github.com/AtariDreams updated https://github.com/llvm/llvm-project/pull/85316
>From 3a1cc2ba9c3b5f5bd290eda890287f3f87803e61 Mon Sep 17 00:00:00 2001
From: Rose <gfunni234 at gmail.com>
Date: Thu, 14 Mar 2024 17:34:16 -0400
Subject: [PATCH] Resolve FIXME: Use class method when receiver is reference to
class
---
clang/lib/Analysis/RetainSummaryManager.cpp | 17 +++++++++++++----
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/clang/lib/Analysis/RetainSummaryManager.cpp b/clang/lib/Analysis/RetainSummaryManager.cpp
index 8d279d969b613..75af876a00ce6 100644
--- a/clang/lib/Analysis/RetainSummaryManager.cpp
+++ b/clang/lib/Analysis/RetainSummaryManager.cpp
@@ -1139,14 +1139,23 @@ const RetainSummary *RetainSummaryManager::getInstanceMethodSummary(
if (!ReceiverClass)
ReceiverClass = ME->getReceiverInterface();
- // FIXME: The receiver could be a reference to a class, meaning that
- // we should use the class method.
+ // The receiver could be a reference to a class, meaning that
+ // we should use the class method if that happens.
// id x = [NSObject class];
// [x performSelector:... withObject:... afterDelay:...];
Selector S = ME->getSelector();
const ObjCMethodDecl *Method = ME->getMethodDecl();
- if (!Method && ReceiverClass)
- Method = ReceiverClass->getInstanceMethod(S);
+ if (!Method) {
+ if (ReceiverClass) {
+ if (ReceiverType->isSpecificBuiltinType(BuiltinType::ObjCClass)) {
+ // The receiver is a class reference, use the class method.
+ Method = ReceiverClass->getClassMethod(S);
+ } else {
+ // The receiver is an instance reference, use the instance method.
+ Method = ReceiverClass->getInstanceMethod(S);
+ }
+ }
+ }
return getMethodSummary(S, ReceiverClass, Method, ME->getType(),
ObjCMethodSummaries);
More information about the cfe-commits
mailing list