[clang] [HLSL][CMake] Cache files don't have generator vars (PR #92793)

via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 10:38:38 PDT 2024


llvmbot wrote:


<!--LLVM PR SUMMARY COMMENT-->

@llvm/pr-subscribers-clang

Author: Chris B (llvm-beanz)

<details>
<summary>Changes</summary>

Doh! CMake cache scripts don't have generator variables set yet, so the script can't depend on the generator variables. Instead I've added a variable that a user can specify to enable the distribution settings.

---
Full diff: https://github.com/llvm/llvm-project/pull/92793.diff


1 Files Affected:

- (modified) clang/cmake/caches/HLSL.cmake (+1-1) 


``````````diff
diff --git a/clang/cmake/caches/HLSL.cmake b/clang/cmake/caches/HLSL.cmake
index 27f848fdccf0c..ed813f60c9c69 100644
--- a/clang/cmake/caches/HLSL.cmake
+++ b/clang/cmake/caches/HLSL.cmake
@@ -12,7 +12,7 @@ set(LLVM_ENABLE_PROJECTS "clang;clang-tools-extra" CACHE STRING "")
 
 set(CLANG_ENABLE_HLSL On CACHE BOOL "")
 
-if (NOT CMAKE_CONFIGURATION_TYPES)
+if (HLSL_ENABLE_DISTRIBUTION)
   set(LLVM_DISTRIBUTION_COMPONENTS
       "clang;hlsl-resource-headers;clangd"
       CACHE STRING "")

``````````

</details>


https://github.com/llvm/llvm-project/pull/92793


More information about the cfe-commits mailing list