[clang] [clang] Introduce `SemaAccess` (PR #92674)

[Erich Keane via cfe-commits]

================
@@ -1459,11 +1460,11 @@ static AccessResult CheckEffectiveAccess(Sema &S,
   llvm_unreachable("invalid access result");
 }
 
-static Sema::AccessResult CheckAccess(Sema &S, SourceLocation Loc,
-                                      AccessTarget &Entity) {
+static SemaAccess::AccessResult CheckAccess(Sema &S, SourceLocation Loc,
----------------
erichkeane wrote:

i find myself wondering if this should just take `SemaAccess` instead of `sema`, with all the below churn.  It seems to make more sense, even if it has to do an extraction of Sema in the function.

https://github.com/llvm/llvm-project/pull/92674