[clang] [clang-repl] Extend the C support. (PR #89804)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Mon May 20 05:48:55 PDT 2024


================
@@ -407,6 +406,16 @@ void IncrementalParser::CleanUpPTU(PartialTranslationUnit &PTU) {
       }
     }
   }
+
+  // FIXME: We should de-allocate MostRecentTU
+  for (Decl *D : MostRecentTU->decls()) {
+    if (!isa<NamedDecl>(D))
+      continue;
+    // Check if we need to clean up the IdResolver chain.
+    NamedDecl *ND = cast<NamedDecl>(D);
----------------
AaronBallman wrote:

isa + cast is a code smell because that is literally doing what dyn_cast does; do you have measurements that suggest there is a measurable performance difference?

https://github.com/llvm/llvm-project/pull/89804


More information about the cfe-commits mailing list