[clang] [Clang] Add support for [[msvc::noinline]] attribute. (PR #91720)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Fri May 17 08:09:27 PDT 2024


================
@@ -1997,9 +1997,12 @@ def Convergent : InheritableAttr {
 def NoInline : DeclOrStmtAttr {
   let Spellings = [CustomKeyword<"__noinline__">, GCC<"noinline">,
                    CXX11<"clang", "noinline">, C23<"clang", "noinline">,
+                   CXX11<"msvc", "noinline">, C23<"msvc", "noinline">,
                    Declspec<"noinline">];
   let Accessors = [Accessor<"isClangNoInline", [CXX11<"clang", "noinline">,
----------------
erichkeane wrote:

I think just a rename.  This is only used to reject this on a statement if it is NOT (currently) the clang spelling, then suggest the clang spelling.  I think the behavior of suggesting `[[clang::noinline]]` is still fine, but `isClangNoInline` isn't an accurate name if spelled `[[msvc::noinline]]`

https://github.com/llvm/llvm-project/pull/91720


More information about the cfe-commits mailing list