[clang] [clang][dataflow] Fully support Environment construction for Stmt analysis. (PR #91616)

[via cfe-commits]

================
@@ -718,16 +730,24 @@ class Environment {
   void pushCallInternal(const FunctionDecl *FuncDecl,
                         ArrayRef<const Expr *> Args);
 
+  // FIXME: Add support for resetting globals after function calls to enable
+  // the implementation of sound analyses.
----------------
martinboehme wrote:

Not sure why this comment is being moved here? It seems to be more removed from the place where we would make this change than where it previously was (i.e. next to the implementation of `initFieldsGlobalsAndFuncs()`.

That said, I'm not sure what this comment is trying to say exactly -- but in any case, I would recommend keeping it where it is. IIUC, this PR isn't making any changes to this behavior?

https://github.com/llvm/llvm-project/pull/91616