[clang] [clang][dataflow] Fully support Environment construction for Stmt analysis. (PR #91616)

[via cfe-commits]

================
@@ -290,13 +295,13 @@ widenKeyToValueMap(const llvm::MapVector<Key, Value *> &CurMap,
 namespace {
 
 // Visitor that builds a map from record prvalues to result objects.
-// This traverses the body of the function to be analyzed; for each result
-// object that it encounters, it propagates the storage location of the result
-// object to all record prvalues that can initialize it.
+// This traverses the AST sub-tree to be visited; for each result object that
+// it encounters, it propagates the storage location of the result object to all
+// record prvalues that can initialize it.
 class ResultObjectVisitor : public RecursiveASTVisitor<ResultObjectVisitor> {
 public:
   // `ResultObjectMap` will be filled with a map from record prvalues to result
-  // object. If the function being analyzed returns a record by value,
+  // object. If the sub-tree to be visited returns a record by value,
----------------
martinboehme wrote:

"sub-tree to be visited returns a record by value": This only makes sense if this sub-tree is actually a function, so I would suggest keeping the wording more specific.

```suggestion
  // object. If the analysis target is a function that returns a record by value,
```

https://github.com/llvm/llvm-project/pull/91616