[clang] [Driver][PS5] Set visibility option defaults (PR #92091)
via cfe-commits
cfe-commits at lists.llvm.org
Tue May 14 02:27:42 PDT 2024
================
@@ -376,24 +382,32 @@ void toolchains::PS4PS5Base::addClangTargetOptions(
else
CC1Args.push_back("-fvisibility-dllexport=protected");
+ // For PS4 we override the visibilty of globals definitions without
+ // dllimport or dllexport annotations.
if (DriverArgs.hasArg(options::OPT_fvisibility_nodllstorageclass_EQ))
DriverArgs.AddLastArg(CC1Args,
options::OPT_fvisibility_nodllstorageclass_EQ);
- else
+ else if (getTriple().isPS4())
CC1Args.push_back("-fvisibility-nodllstorageclass=hidden");
+ else
+ CC1Args.push_back("-fvisibility-nodllstorageclass=keep");
if (DriverArgs.hasArg(options::OPT_fvisibility_externs_dllimport_EQ))
DriverArgs.AddLastArg(CC1Args,
options::OPT_fvisibility_externs_dllimport_EQ);
else
CC1Args.push_back("-fvisibility-externs-dllimport=default");
+ // For PS4 we override the visibilty of external globals without
----------------
bd1976bris wrote:
Note for reviewer: This comment is new and replaces a comment in our downstream code that wasn't suitable for upstream as it referenced internal tracking numbers.
https://github.com/llvm/llvm-project/pull/92091
More information about the cfe-commits
mailing list