[clang] [clang] Disallow VLA type compound literals (PR #91891)

via cfe-commits cfe-commits at lists.llvm.org
Mon May 13 05:09:16 PDT 2024


Jim M. R. =?utf-8?q?Teichgräber?=,Jim M. R. =?utf-8?q?Teichgräber?Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/91891 at github.com>


Sirraide wrote:

> > Btw, you can probably move this PR out of Draft status, it seems awfully close to finished
> 
> I'll finish implementing your suggestions, run the tests again locally and then move it out of draft, if that's alright with you :).

Either way is fine I’d say, but the thing is that I personally at least would use draft prs mainly for something where I’m nowhere close to done and it’s not really ready for review because things are probably going to change, but I just want to signal that I’m working on it. If it’s something that’s mostly done or which is at least mostly review-ready, then I’d just use a regular pr, but that’s just how I do it.

https://github.com/llvm/llvm-project/pull/91891


More information about the cfe-commits mailing list