[clang-tools-extra] [NFC][clang-tidy] remove magic-numbers-todo.cpp (PR #91577)
via cfe-commits
cfe-commits at lists.llvm.org
Thu May 9 02:51:41 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang-tidy
Author: Congcong Cai (HerrCai0907)
<details>
<summary>Changes</summary>
This XFAIL test is written in 4 years ago and still todo.
4 is already in DefaultIgnoredIntegerValues so I do not think this XFAIL case can be passed.
---
Full diff: https://github.com/llvm/llvm-project/pull/91577.diff
1 Files Affected:
- (removed) clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp (-15)
``````````diff
diff --git a/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp b/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp
deleted file mode 100644
index 99d9be262a897..0000000000000
--- a/clang-tools-extra/test/clang-tidy/checkers/readability/magic-numbers-todo.cpp
+++ /dev/null
@@ -1,15 +0,0 @@
-// RUN: %check_clang_tidy %s readability-magic-numbers %t --
-// XFAIL: *
-
-int ProcessSomething(int input);
-
-int DoWork()
-{
- if (((int)4) > ProcessSomething(10))
- // CHECK-MESSAGES: :[[@LINE-1]]:13: warning: 4 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
- return 0;
-
- return 0;
-}
-
-
``````````
</details>
https://github.com/llvm/llvm-project/pull/91577
More information about the cfe-commits
mailing list