[clang] [llvm] [BPF] Fix linking issues in static map initializers (PR #91310)

[Eli Friedman via cfe-commits]

================
@@ -1950,8 +1950,22 @@ ConstantLValueEmitter::tryEmitBase(const APValue::LValueBase &base) {
     if (D->hasAttr<WeakRefAttr>())
       return CGM.GetWeakRefReference(D).getPointer();
 
-    if (auto FD = dyn_cast<FunctionDecl>(D))
-      return CGM.GetAddrOfFunction(FD);
+    if (auto FD = dyn_cast<FunctionDecl>(D)) {
+      auto *C = CGM.GetAddrOfFunction(FD);
+
+      // we don't normally emit debug info for extern fns referenced via
+      // variable initialisers; BPF needs it since it generates BTF from
+      // debug info and bpftool demands BTF for every symbol linked
+      if (CGM.getTarget().getTriple().isBPF() && FD->getStorageClass() == SC_Extern) {
----------------
efriedma-quic wrote:

There's an existing hook allowDebugInfoForExternalRef() for which targets want this.

You almost never want getStorageClass(); if you care about linkage, we have different methods for that.

https://github.com/llvm/llvm-project/pull/91310