[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)
via cfe-commits
cfe-commits at lists.llvm.org
Mon May 6 19:28:19 PDT 2024
dhruvachak wrote:
I think OmptCallback.cpp can be completely removed from the plugin since that functionality is subsumed by offload. As in
```
diff --git a/offload/plugins-nextgen/common/CMakeLists.txt b/offload/plugins-nextgen/common/CMakeLists.txt
index acf0af63f050..dc942db826bf 100644
--- a/offload/plugins-nextgen/common/CMakeLists.txt
+++ b/offload/plugins-nextgen/common/CMakeLists.txt
@@ -46,7 +46,6 @@ endif()
# If we have OMPT enabled include it in the list of sources.
if (OMPT_TARGET_DEFAULT AND LIBOMPTARGET_OMPT_SUPPORT)
- target_sources(PluginCommon PRIVATE OMPT/OmptCallback.cpp)
target_include_directories(PluginCommon PRIVATE OMPT)
endif()
```
https://github.com/llvm/llvm-project/pull/87009
More information about the cfe-commits
mailing list