[clang] [llvm] [Libomptarget] Statically link all plugin runtimes (PR #87009)
Joseph Huber via cfe-commits
cfe-commits at lists.llvm.org
Mon May 6 14:31:24 PDT 2024
jhuber6 wrote:
> There are duplicate definitions of the following
>
> ```
> bool llvm::omp::target::ompt::Initialized = false;
>
> ompt_get_callback_t llvm::omp::target::ompt::lookupCallbackByCode = nullptr;
> ompt_function_lookup_t llvm::omp::target::ompt::lookupCallbackByName = nullptr;
> ```
>
> in src/OpenMP/OMPT/Callback.cpp and plugins-nextgen/common/OMPT/OmptCallback.cpp
>
> Can you remove the ones in the plugin? Otherwise, it's not clear which definition is being used.
Sure, do you get that upstream? If so, wonder why I didn't get it.
I guess we would just have it to where the `libomptarget` instance handles all the OMPT.
https://github.com/llvm/llvm-project/pull/87009
More information about the cfe-commits
mailing list