[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

Chris Apple via cfe-commits cfe-commits at lists.llvm.org
Sat May 4 06:11:15 PDT 2024


================
@@ -18347,7 +18347,7 @@ void Sema::SetFunctionBodyKind(Decl *D, SourceLocation Loc, FnBodyKind BodyKind,
   }
 }
 
-bool Sema::CheckOverridingFunctionAttributes(const CXXMethodDecl *New,
+bool Sema::CheckOverridingFunctionAttributes(CXXMethodDecl *New,
----------------
cjappl wrote:

It seems possibly strange to me that a function called "Check" would mutate a value passed into it. I would expect it to be passive.

Can the mutation come later, or in a different function, or perhaps this should be renamed?

https://github.com/llvm/llvm-project/pull/84983


More information about the cfe-commits mailing list