[clang-tools-extra] [run-clang-tidy.py] Refactor, add progress indicator, add type hints (PR #89490)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Sat Apr 27 12:44:56 PDT 2024


https://github.com/PiotrZSL commented:

One issue, looks like only stdout is buffered, and when clang-tidy output:

"26035 warnings generated.
Suppressed 26030 warnings (26030 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

26005 warnings generated.
Suppressed 26002 warnings (26002 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.

25999 warnings generated.
Suppressed 25996 warnings (25996 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
"

it's just displayed without point to an file that produced this output.
This is what I see when redirecting output to file with "&> output.txt".
Looks like without redirection to file works fine.

Second issue, is that it takes a while before first output is being shown to user.
Would be nice if we would show something like "Running clang-tidy for XYZ files out of ZXY in compilation database", or something like this.

You may consider adding also an timer how long command took for every file.
Could be usefull

https://github.com/llvm/llvm-project/pull/89490


More information about the cfe-commits mailing list