[clang] [OpenCL] Put constant initializer globals into constant addrspace (PR #90048)

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 26 11:28:02 PDT 2024


================
@@ -536,6 +536,8 @@ void AggExprEmitter::EmitArrayInit(Address DestPtr, llvm::ArrayType *AType,
     CodeGen::CodeGenModule &CGM = CGF.CGM;
     ConstantEmitter Emitter(CGF);
     LangAS AS = ArrayQTy.getAddressSpace();
+    if (CGF.getLangOpts().OpenCL)
+      AS = LangAS::opencl_constant;
----------------
efriedma-quic wrote:

That's true as far as it goes, but I'd prefer to make this a bit more general...

It looks like there's an existing GetGlobalConstantAddressSpace() which computes what we want here?

https://github.com/llvm/llvm-project/pull/90048


More information about the cfe-commits mailing list