[clang] [clang-tools-extra] [clangd] Show struct fields and enum members in hovers (PR #89557)

Nathan Ridge via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 23 23:50:36 PDT 2024


HighCommander4 wrote:

> I have a few questions:
> 
>    1. Do we want an RFC in discourse for the changes in `DeclPrinter`?

An RFC might be overkill, but asking for review from a clang code owner for changes to an interface such as `PrintingPolicy` or `PrintingCallbacks` is probably a good idea. (If the clang reviewer feels an RFC is warranted, we can do it then.)

>    2. Do you think we should also add some test cases to `DeclPrinterTest.cpp`?

Yep, good call!

https://github.com/llvm/llvm-project/pull/89557


More information about the cfe-commits mailing list