[clang] [clang][dataflow] Model conditional operator correctly. (PR #89213)

via cfe-commits cfe-commits at lists.llvm.org
Fri Apr 19 00:31:22 PDT 2024


================
@@ -657,17 +658,25 @@ class TransferVisitor : public ConstStmtVisitor<TransferVisitor> {
   }
 
   void VisitConditionalOperator(const ConditionalOperator *S) {
-    // FIXME: Revisit this once flow conditions are added to the framework. For
-    // `a = b ? c : d` we can add `b => a == c && !b => a == d` to the flow
-    // condition.
-    // When we do this, we will need to retrieve the values of the operands from
-    // the environments for the basic blocks they are computed in, in a similar
-    // way to how this is done for short-circuited logical operators in
-    // `getLogicOperatorSubExprValue()`.
-    if (S->isGLValue())
-      Env.setStorageLocation(*S, Env.createObject(S->getType()));
-    else if (!S->getType()->isRecordType()) {
-      if (Value *Val = Env.createValue(S->getType()))
+    const Environment *TrueEnv = StmtToEnv.getEnvironment(*S->getTrueExpr());
+    const Environment *FalseEnv = StmtToEnv.getEnvironment(*S->getFalseExpr());
+
+    if (TrueEnv == nullptr || FalseEnv == nullptr)
----------------
martinboehme wrote:

Good point. This is just a defence against crashes in production if we unexpectedly don't find an environment; but obviously this means the bailout should be paired with an assertion, which I have now added.

https://github.com/llvm/llvm-project/pull/89213


More information about the cfe-commits mailing list