[clang] nonblocking/nonallocating attributes (was: nolock/noalloc) (PR #84983)

via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 16 07:44:30 PDT 2024


Sirraide wrote:

> have the effect sets be part of `Sema`

That’s fine so long as the `FunctionProtoType` doesn’t have to store an effect set.

> There's another possibility where `Sema` itself does the work, but that header file is something like 16000 lines...

I don’t think that’s really a problem. We do have some long files, though someone is currently working on breaking Sema up into more manageable parts. Either way, I’d put it in Sema because a member function on a `Type` that takes a `Sema&` seems really weird, at least to me.



https://github.com/llvm/llvm-project/pull/84983


More information about the cfe-commits mailing list