[clang] [clang] Constexpr for __builtin_shufflevector and __builtin_convertvector (PR #76615)

via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 15 13:46:36 PDT 2024


Pol Marcet =?utf-8?q?Sardà?= <polmarcetsarda at gmail.com>,
Pol Marcet =?utf-8?q?Sardà?= <polmarcetsarda at gmail.com>,
Pol Marcet =?utf-8?q?Sardà?= <polmarcetsarda at gmail.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/76615 at github.com>


sethp wrote:

That sounds right to me; the tasks I see are:

- [ ] Expanding the test cases for `__builtin_convertvector`
- [ ] Rewording the diagnostic for -1 in `__builtin_shufflevector`
- [ ] Rewording the comment for -1 in `__builtin_shufflevector`
- [ ] A stylistic change to `__builtin_convertvector`
- [ ] Considering adding a diagnostic for `__builtin_convertvector` in case we "fall through" to the bottom (which we think is currently impossible)
- [ ] ReleaseNotes.rst

Of those, I think the only one that isn't pretty much purely mechanical is whether or not we add the extra diagnostic. 

Let me know if I missed anything, or if there's anything I can do to help get this one over the finish line: thanks so much @Destroyerrrocket for all your work already!



https://github.com/llvm/llvm-project/pull/76615


More information about the cfe-commits mailing list