[clang] [clang/DependencyScanning/ModuleDepCollector] Refactor part of `makeCommonInvocationForModuleBuild` into its own function (PR #88447)

[Argyrios Kyrtzidis via cfe-commits]

akyrtzi wrote:

> I assume you'll call resetBenignCodeGenOptions() from ModuleDepCollector::applyDiscoveredDependencies() in a follow-up, non-NFC patch, right?

@jansvoboda11 see updated commit, I made the change per your suggestion.

https://github.com/llvm/llvm-project/pull/88447