https://github.com/erichkeane approved this pull request. 2 nits, else LGTM. Once you and @kimgr are in agreement with what to do next (and have looked into my nits), feel free to commit. https://github.com/llvm/llvm-project/pull/88600