[clang-tools-extra] [clangd] Avoid using CompletionItemKind.Text for macro completions from the index (PR #88236)

Haojian Wu via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 12:28:36 PDT 2024


================
@@ -89,7 +89,9 @@ const CodeCompleteOptions::CodeCompletionRankingModel
 
 namespace {
 
-CompletionItemKind toCompletionItemKind(index::SymbolKind Kind) {
+CompletionItemKind
+toCompletionItemKind(index::SymbolKind Kind,
+                     const llvm::StringRef *Signature = nullptr) {
----------------
hokein wrote:

nit: can you add a comment stating that this function needs to remain synchronized with the one below?

https://github.com/llvm/llvm-project/pull/88236


More information about the cfe-commits mailing list