[clang] 85bc6de - Revert "Use setup_host_tool for clang-ast-dump, fixes 76707"

Timm Bäder via cfe-commits cfe-commits at lists.llvm.org
Thu Apr 11 00:50:16 PDT 2024


Author: Timm Bäder
Date: 2024-04-11T09:50:03+02:00
New Revision: 85bc6de67ef28cd203da0c5abc1485609bea989c

URL: https://github.com/llvm/llvm-project/commit/85bc6de67ef28cd203da0c5abc1485609bea989c
DIFF: https://github.com/llvm/llvm-project/commit/85bc6de67ef28cd203da0c5abc1485609bea989c.diff

LOG: Revert "Use setup_host_tool for clang-ast-dump, fixes 76707"

This reverts commit b4adb42151bbfa80be4cf6d076cbe5edf680693e.

The original commit increased local rebuild times a lot. See
the discussion in
https://github.com/llvm/llvm-project/issues/76707

Added: 
    

Modified: 
    clang/lib/Tooling/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/clang/lib/Tooling/CMakeLists.txt b/clang/lib/Tooling/CMakeLists.txt
index 8b4ab0e2129649..91e6cbdcbc44f7 100644
--- a/clang/lib/Tooling/CMakeLists.txt
+++ b/clang/lib/Tooling/CMakeLists.txt
@@ -53,16 +53,14 @@ else()
     list(APPEND implicitDirs -I ${implicitDir})
   endforeach()
 
-  setup_host_tool(clang-ast-dump CLANG_AST_DUMP clang_ast_dump_exe clang_ast_dump_target)
-
   include(GetClangResourceDir)
   get_clang_resource_dir(resource_dir PREFIX ${LLVM_BINARY_DIR})
   add_custom_command(
       COMMENT Generate ASTNodeAPI.json
       OUTPUT ${CMAKE_CURRENT_BINARY_DIR}/ASTNodeAPI.json
-      DEPENDS ${clang_ast_dump_target} clang-resource-headers
+      DEPENDS clang-ast-dump clang-resource-headers
       COMMAND
-      ${clang_ast_dump_exe}
+      $<TARGET_FILE:clang-ast-dump>
         # Skip this in debug mode because parsing AST.h is too slow
         --skip-processing=${skip_expensive_processing}
         -I ${resource_dir}/include


        


More information about the cfe-commits mailing list