[clang] [Clang][AST][NFC] Fix printing of dependent PackIndexTypes (PR #88146)
via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 9 09:10:16 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: Krystian Stasiowski (sdkrystian)
<details>
<summary>Changes</summary>
Dependent `PackIndexType`s currently print the memory address of the index `Expr*` rather than pretty printing the expression. This patch fixes that.
---
Full diff: https://github.com/llvm/llvm-project/pull/88146.diff
1 Files Affected:
- (modified) clang/lib/AST/TypePrinter.cpp (+6-3)
``````````diff
diff --git a/clang/lib/AST/TypePrinter.cpp b/clang/lib/AST/TypePrinter.cpp
index 075c8aba11fcb9..9602f448e94279 100644
--- a/clang/lib/AST/TypePrinter.cpp
+++ b/clang/lib/AST/TypePrinter.cpp
@@ -1213,10 +1213,13 @@ void TypePrinter::printDecltypeBefore(const DecltypeType *T, raw_ostream &OS) {
void TypePrinter::printPackIndexingBefore(const PackIndexingType *T,
raw_ostream &OS) {
- if (T->hasSelectedType())
+ if (T->hasSelectedType()) {
OS << T->getSelectedType();
- else
- OS << T->getPattern() << "...[" << T->getIndexExpr() << "]";
+ } else {
+ OS << T->getPattern() << "...[";
+ T->getIndexExpr()->printPretty(OS, nullptr, Policy);
+ OS << "]";
+ }
spaceBeforePlaceHolder(OS);
}
``````````
</details>
https://github.com/llvm/llvm-project/pull/88146
More information about the cfe-commits
mailing list