[clang] Rework the printing of attributes (PR #87281)

Giuliano Belinassi via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 9 06:57:37 PDT 2024


giulianobelinassi wrote:

> Maybe you can open a PR against the branch?

Sorry, but I can only do this tomorrow. Feel free to open the PR if you need it immediately.

> And `final` as well as `override`? (This is why I'm not convinced we should be backporting anything -- the problem is with printing in general and will crop up in various places, so we're not really fixing a regression so much as playing whack-a-mole with a few cases.)

Why not? `override` and perhaps `final` output is broken so I'd say we fix this on LLVM-18. It is better than leave it broken. I don't think this will break many test cases once this bug got undetected.

https://github.com/llvm/llvm-project/pull/87281


More information about the cfe-commits mailing list