[clang] [CUDA][HIP] Fix record layout on Windows (PR #87651)
Yaxun Liu via cfe-commits
cfe-commits at lists.llvm.org
Fri Apr 5 06:50:59 PDT 2024
yxsamliu wrote:
> > Keeping layout in sync makes sense to me, but I'm completely unfamiliar with the windows side.
> > @rnk is there anything else we need to worry about?
>
> I checked, and I think this routes everything over to the MS record layout builder, so it should be comprehensive:
>
> https://github.com/llvm/llvm-project/blob/d97d560fbf6ed26a198b3afe1594d7d63b88ab3a/clang/lib/AST/RecordLayoutBuilder.cpp#L3354
>
> I would augment the test a bit, but otherwise this looks good to me.
will add more tests about field access and virtual function calls
https://github.com/llvm/llvm-project/pull/87651
More information about the cfe-commits
mailing list