[clang] [Clang][Sema] Skip checking anonymous enum in using enum declaration (PR #87144)
Qizhi Hu via cfe-commits
cfe-commits at lists.llvm.org
Thu Apr 4 17:39:05 PDT 2024
https://github.com/jcsxky updated https://github.com/llvm/llvm-project/pull/87144
>From c4adc66660ae83294e4524f2740a40eee483c2cb Mon Sep 17 00:00:00 2001
From: huqizhi <huqizhi at feysh.com>
Date: Sat, 30 Mar 2024 14:47:00 +0800
Subject: [PATCH] [Clang][Sema] Skip checking anonymous enum in using enum
declaration
---
clang/docs/ReleaseNotes.rst | 1 +
clang/lib/Sema/SemaDecl.cpp | 4 ++++
clang/test/SemaCXX/PR86790.cpp | 32 ++++++++++++++++++++++++++++++++
3 files changed, 37 insertions(+)
create mode 100644 clang/test/SemaCXX/PR86790.cpp
diff --git a/clang/docs/ReleaseNotes.rst b/clang/docs/ReleaseNotes.rst
index 8fc925350849cd..f33f67cdbd0fc5 100644
--- a/clang/docs/ReleaseNotes.rst
+++ b/clang/docs/ReleaseNotes.rst
@@ -494,6 +494,7 @@ Bug Fixes to C++ Support
- Fix crash when inheriting from a cv-qualified type. Fixes:
(`#35603 <https://github.com/llvm/llvm-project/issues/35603>`_)
+- Fix a crash when the using enum declaration uses an anonymous enumeration. Fixes (#GH86790).
Bug Fixes to AST Handling
^^^^^^^^^^^^^^^^^^^^^^^^^
diff --git a/clang/lib/Sema/SemaDecl.cpp b/clang/lib/Sema/SemaDecl.cpp
index 5c1152896559b5..ba0ce433a39789 100644
--- a/clang/lib/Sema/SemaDecl.cpp
+++ b/clang/lib/Sema/SemaDecl.cpp
@@ -1537,6 +1537,10 @@ void Sema::PushOnScopeChains(NamedDecl *D, Scope *S, bool AddToContext) {
cast<FunctionDecl>(D)->isFunctionTemplateSpecialization())
return;
+ if (isa<UsingEnumDecl>(D) && D->getDeclName().isEmpty()) {
+ S->AddDecl(D);
+ return;
+ }
// If this replaces anything in the current scope,
IdentifierResolver::iterator I = IdResolver.begin(D->getDeclName()),
IEnd = IdResolver.end();
diff --git a/clang/test/SemaCXX/PR86790.cpp b/clang/test/SemaCXX/PR86790.cpp
new file mode 100644
index 00000000000000..09e9bb3505e1bf
--- /dev/null
+++ b/clang/test/SemaCXX/PR86790.cpp
@@ -0,0 +1,32 @@
+// RUN: %clang_cc1 -verify -std=c++20 -fsyntax-only %s
+
+enum {A, S, D, F};
+int main() {
+ using asdf = decltype(A);
+ using enum asdf; // this line causes the crash
+ return 0;
+}
+
+namespace N1 {
+ enum {A, S, D, F};
+ constexpr struct T {
+ using asdf = decltype(A);
+ using enum asdf;
+ } t;
+
+ static_assert(t.D == D);
+ static_assert(T::S == S);
+}
+
+namespace N2 {
+ enum {A, S, D, F};
+ constexpr struct T {
+ struct {
+ using asdf = decltype(A);
+ using enum asdf;
+ } inner;
+ } t;
+
+ static_assert(t.inner.D == D);
+ static_assert(t.D == D); // expected-error {{no member named 'D' in 'N2::T'}}
+}
More information about the cfe-commits
mailing list