[clang] bcac3ed - Revert "[NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (#75254)"

Mitch Phillips via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 2 07:16:59 PDT 2024


Author: Mitch Phillips
Date: 2024-04-02T16:15:45+02:00
New Revision: bcac3edac80044962d5dfe96b96f781fa0a70b2e

URL: https://github.com/llvm/llvm-project/commit/bcac3edac80044962d5dfe96b96f781fa0a70b2e
DIFF: https://github.com/llvm/llvm-project/commit/bcac3edac80044962d5dfe96b96f781fa0a70b2e.diff

LOG: Revert "[NFC][clang][test][asan] Make `instantiation-depth-default.cpp` a valid test case under `asan` and `ubsan` configs (#75254)"

Disables the recursive template expansion test under ASan again. This
patch re-enabled this test with sanitizers, but it's started spuriously
failing with a stack overflow again on AArch64+ASan:
https://lab.llvm.org/buildbot/#/builders/239/builds/6363

This reverts commit c458f928fad7bbcf08ab1da9949eb2969fc9f89c.

Added: 
    

Modified: 
    clang/test/SemaTemplate/instantiation-depth-default.cpp

Removed: 
    


################################################################################
diff  --git a/clang/test/SemaTemplate/instantiation-depth-default.cpp b/clang/test/SemaTemplate/instantiation-depth-default.cpp
index 430d042d7e0f49..f5835b86b3a385 100644
--- a/clang/test/SemaTemplate/instantiation-depth-default.cpp
+++ b/clang/test/SemaTemplate/instantiation-depth-default.cpp
@@ -1,12 +1,18 @@
-// RUN: %clang_cc1 -fsyntax-only -verify -ftemplate-backtrace-limit=2 %if {{asan|ubsan}} %{ -Wno-stack-exhausted %} %s
+// RUN: %clang_cc1 -fsyntax-only -verify -ftemplate-backtrace-limit=2 %s
+//
+// FIXME: Disable this test when Clang was built with ASan, because ASan
+// increases our per-frame stack usage enough that this test no longer fits
+// within our normal stack space allocation.
+// UNSUPPORTED: asan
+//
 // The default stack size on NetBSD is too small for this test.
 // UNSUPPORTED: system-netbsd
 
 template<int N, typename T> struct X : X<N+1, T*> {};
-// expected-error-re at 5 {{recursive template instantiation exceeded maximum depth of 1024{{$}}}}
-// expected-note at 5 {{instantiation of template class}}
-// expected-note at 5 {{skipping 1023 contexts in backtrace}}
-// expected-note at 5 {{use -ftemplate-depth=N to increase recursive template instantiation depth}}
+// expected-error-re at 11 {{recursive template instantiation exceeded maximum depth of 1024{{$}}}}
+// expected-note at 11 {{instantiation of template class}}
+// expected-note at 11 {{skipping 1023 contexts in backtrace}}
+// expected-note at 11 {{use -ftemplate-depth=N to increase recursive template instantiation depth}}
 
 X<0, int> x; // expected-note {{in instantiation of}}
 


        


More information about the cfe-commits mailing list