[clang] [Sema] Mark alias/ifunc targets used and consider mangled names (PR #87130)
Erich Keane via cfe-commits
cfe-commits at lists.llvm.org
Tue Apr 2 07:16:33 PDT 2024
================
@@ -1980,6 +1981,23 @@ static void handleWeakRefAttr(Sema &S, Decl *D, const ParsedAttr &AL) {
D->addAttr(::new (S.Context) WeakRefAttr(S.Context, AL));
}
+// Mark alias/ifunc target as used. For C++, we look up the demangled name
+// ignoring parameters. This should handle the majority of use cases while
+// leaveing false positives for namespace scope names and false negatives in
+// the presence of overloads.
+static void markUsedForAliasOrIfunc(Sema &S, Decl *D, const ParsedAttr &AL,
+ StringRef Str) {
+ char *Demangled = llvm::itaniumDemangle(Str, /*ParseParams=*/false);
----------------
erichkeane wrote:
Isn't that diagnostic just a warning? FWIW, I think being as 'defensive' as possible here based on the reporter is worth while.
https://github.com/llvm/llvm-project/pull/87130
More information about the cfe-commits
mailing list