[clang] [clang][dataflow] Refactor `widen` API to be explicit about change effect. (PR #87233)

via cfe-commits cfe-commits at lists.llvm.org
Tue Apr 2 00:48:07 PDT 2024


================
@@ -805,6 +805,25 @@ class NullPointerAnalysis final
     else
       JoinedVal.setProperty("is_null", JoinedEnv.makeTopBoolValue());
   }
+
+  std::optional<WidenResult> widen(QualType Type, Value &Prev,
+                                   const Environment &PrevEnv, Value &Current,
+                                   Environment &CurrentEnv) override {
----------------
martinboehme wrote:

This appears to be more than an API change in that this model didn't have a widening operation at all before. Can you explain why this has been added? (Is it necessary as part of this patch, or just an additional embellishment?)

https://github.com/llvm/llvm-project/pull/87233


More information about the cfe-commits mailing list