[clang] [codegen] Emit missing cleanups for stmt-expr and coro suspensions [take-2] (PR #85398)

Eli Friedman via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 1 12:01:20 PDT 2024


================
@@ -1105,19 +1105,24 @@ void CodeGenFunction::EmitNewArrayInitializer(
     }
 
     // Enter a partial-destruction Cleanup if necessary.
-    if (needsEHCleanup(DtorKind)) {
+    if (DtorKind) {
+      AllocaTrackerRAII AllocaTracker(*this);
----------------
efriedma-quic wrote:

"AllocaTracker" seems like overkill; CreateTempAlloca has an out parameter to access the created alloca, and I don't think you're creating any other allocas.

https://github.com/llvm/llvm-project/pull/85398


More information about the cfe-commits mailing list