[clang] [Clang][Sema] Diagnose class member access expressions naming non-existent members of the current instantiation prior to instantiation in the absence of dependent base classes (PR #84050)

Erich Keane via cfe-commits cfe-commits at lists.llvm.org
Mon Apr 1 09:41:27 PDT 2024


================
@@ -131,7 +131,9 @@ struct BuiltinTypeDeclBuilder {
     DeclarationNameInfo NameInfo =
         DeclarationNameInfo(DeclarationName(&II), SourceLocation());
     LookupResult R(S, NameInfo, Sema::LookupOrdinaryName);
-    S.LookupParsedName(R, S.getCurScope(), &SS, false);
+    S.LookupParsedName(R, S.getCurScope(), &SS,
+                       /*ObjectType=*/QualType(),
+                       /*AllowBuiltinCreation*/ false);
----------------
erichkeane wrote:

Also, why is this specifying 'false' here, which is the default? I realize it was already there, but we should probably not be.

Also-also-- I think this many default arguments has hit the point for ME where we just need an overload for the version where it would be 'all the default things' and specify for everything else.  This is out of hand.

https://github.com/llvm/llvm-project/pull/84050


More information about the cfe-commits mailing list