[clang-tools-extra] Add clang-tidy check readability-math-missing-parentheses (PR #84481)
Bhuminjay Soni via cfe-commits
cfe-commits at lists.llvm.org
Mon Apr 1 08:31:08 PDT 2024
================
@@ -0,0 +1,112 @@
+//===--- MathMissingParenthesesCheck.cpp - clang-tidy ---------------------===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
+//
+//===----------------------------------------------------------------------===//
+
+#include "MathMissingParenthesesCheck.h"
+#include "clang/AST/ASTContext.h"
+#include "clang/ASTMatchers/ASTMatchFinder.h"
+#include "clang/Lex/Lexer.h"
+
+using namespace clang::ast_matchers;
+
+namespace clang::tidy::readability {
+
+void MathMissingParenthesesCheck::registerMatchers(MatchFinder *Finder) {
+ Finder->addMatcher(binaryOperator(unless(hasParent(binaryOperator())),
+ unless(allOf(hasOperatorName("&&"),
+ hasOperatorName("||"))),
+ hasDescendant(binaryOperator()))
+ .bind("binOp"),
+ this);
+}
+
+static int getPrecedence(const BinaryOperator *BinOp) {
+ if (!BinOp)
+ return 0;
+ switch (BinOp->getOpcode()) {
+ case BO_Mul:
+ case BO_Div:
+ case BO_Rem:
+ return 5;
+ case BO_Add:
+ case BO_Sub:
+ return 4;
+ case BO_And:
+ return 3;
+ case BO_Xor:
+ return 2;
+ case BO_Or:
+ return 1;
+ default:
+ return 0;
+ }
+}
+static bool addParantheses(
+ const BinaryOperator *BinOp, const BinaryOperator *ParentBinOp,
+ std::vector<
+ std::pair<clang::SourceRange, std::pair<const clang::BinaryOperator *,
+ const clang::BinaryOperator *>>>
+ &Insertions,
+ const clang::SourceManager &SM, const clang::LangOptions &LangOpts) {
+ bool NeedToDiagnose = false;
+ if (!BinOp)
+ return NeedToDiagnose;
+
+ if (ParentBinOp != nullptr &&
+ getPrecedence(BinOp) != getPrecedence(ParentBinOp)) {
+ NeedToDiagnose = true;
+ const clang::SourceLocation StartLoc = BinOp->getBeginLoc();
+ clang::SourceLocation EndLoc =
+ clang::Lexer::getLocForEndOfToken(BinOp->getEndLoc(), 0, SM, LangOpts);
+ Insertions.push_back(
+ {clang::SourceRange(StartLoc, EndLoc), {BinOp, ParentBinOp}});
----------------
11happy wrote:
done
https://github.com/llvm/llvm-project/pull/84481
More information about the cfe-commits
mailing list