[clang] [compiler-rt] [llvm] [InstrFDO][TypeProf] Implement binary instrumentation and profile read/write (PR #66825)

Mingming Liu via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 28 11:00:17 PDT 2024


minglotus-6 wrote:

> I think we should resort to scripts and profraw in LLVM if we don't have support for textual format. This is the case for memprof for example. 

Got it. I updated the test cases. Now compiler-rt test provides raw-related test coverage, and IR test provides test coverage for the {show, merge} related with {indexed, text} formats.

> It seems cleanest if the allocator and the map are owned by the InstrProfSymtab class.

Agree. With https://github.com/llvm/llvm-project/pull/86882, InstrProfSymtab could own both. Thanks for the discussion!
- Added a few [lines](https://github.com/llvm/llvm-project/pull/66825/commits/01585236e7c350830544482c9917320a75e9ac57#diff-f959bf0ff4ce781c36e6eddb19d46fadb78e0c79fa13f7df384bb72f38fcf405) in unit test to have some test coverage for the IntervalMap usage.


https://github.com/llvm/llvm-project/pull/66825


More information about the cfe-commits mailing list