[clang] [CGBuiltin] Use freeze instruction to create an undef value instead of zero (PR #86967)
via cfe-commits
cfe-commits at lists.llvm.org
Thu Mar 28 09:13:54 PDT 2024
llvmbot wrote:
<!--LLVM PR SUMMARY COMMENT-->
@llvm/pr-subscribers-clang
Author: AtariDreams (AtariDreams)
<details>
<summary>Changes</summary>
---
Full diff: https://github.com/llvm/llvm-project/pull/86967.diff
1 Files Affected:
- (modified) clang/lib/CodeGen/CGBuiltin.cpp (+3-5)
``````````diff
diff --git a/clang/lib/CodeGen/CGBuiltin.cpp b/clang/lib/CodeGen/CGBuiltin.cpp
index 5ab5917c0c8da7..179c0cf3cc905a 100644
--- a/clang/lib/CodeGen/CGBuiltin.cpp
+++ b/clang/lib/CodeGen/CGBuiltin.cpp
@@ -14305,11 +14305,9 @@ Value *CodeGenFunction::EmitX86BuiltinExpr(unsigned BuiltinID,
case X86::BI__builtin_ia32_undef256:
case X86::BI__builtin_ia32_undef512:
// The x86 definition of "undef" is not the same as the LLVM definition
- // (PR32176). We leave optimizing away an unnecessary zero constant to the
- // IR optimizer and backend.
- // TODO: If we had a "freeze" IR instruction to generate a fixed undef
- // value, we should use that here instead of a zero.
- return llvm::Constant::getNullValue(ConvertType(E->getType()));
+ // (PR32176). Use a "freeze" IR instruction to generate a fixed undef
+ // value.
+ return Builder.CreateFreeze(UndefValue::get(ConvertType(E->getType())));
case X86::BI__builtin_ia32_vec_init_v8qi:
case X86::BI__builtin_ia32_vec_init_v4hi:
case X86::BI__builtin_ia32_vec_init_v2si:
``````````
</details>
https://github.com/llvm/llvm-project/pull/86967
More information about the cfe-commits
mailing list