[clang] [llvm] [AIX][TOC] Add -mtocdata/-mno-tocdata options on AIX (PR #67999)

[Zaara Syeda via cfe-commits]

syzaara wrote:

> I'm seeing test failures locally when compiling with `LLVM_REVERSE_ITERATION=ON`. I'm surprised this hasn't failed on buildbot.
> 
> ```
> clang/test/Driver/toc-conf.c:22:18: error: CHECK-EQCONF: expected string not found in input
> // CHECK-EQCONF: "-mtocdata=g3,g4"
>                  ^
> <stdin>:5:385: note: scanning from here
>  "/usr/local/google/home/paulkirth/llvm-fork/build/bin/llvm" "clang" "-cc1" "-triple" "powerpc-unknown-aix" "-emit-obj" "-mrelax-all" "-dumpdir" "a-" "-disable-free" "-clear-ast-before-backend" "-main-file-name" "toc-conf.c" "-mrelocation-model" "pic" "-pic-level" "2" "-mframe-pointer=all" "-fmath-errno" "-ffp-contract=on" "-fno-rounding-math" "-mconstructor-aliases" "-mno-tocdata" "-mtocdata=g4,g3" "-fxl-pragma-pack" "-target-cpu" "pwr7" "-mfloat-abi" "hard" "-gstrict-dwarf" "-gno-column-info" "-fdebug-compilation-dir=/usr/local/google/home/paulkirth/llvm-fork/build" "-fdata-sections" "-fcoverage-compilation-dir=/usr/local/google/home/paulkirth/llvm-fork/build" "-resource-dir" "/usr/local/google/home/paulkirth/llvm-fork/build/lib/clang/19" "-internal-isystem" "/usr/local/google/home/paulkirth/llvm-fork/build/lib/clang/19/include/ppc_wrappers" "-internal-isystem" "/usr/local/google/home/paulkirth/llvm-fork/build/lib/clang/19/include" "-internal-isystem" "/usr/include" "-ferror-limit" "19" "-fno-signed-char" "-fno-use-cxa-atexit" "-fgnuc-version=4.2.1" "-fskip-odr-check-in-gmf" "-o" "/tmp/toc-conf-f15b3c.o" "-x" "c" "/usr/local/google/home/paulkirth/llvm-fork/clang/test/Driver/toc-conf.c"
> ```
> 
> If you notice, the arg ordering is reversed (`g4,g3`). I think this is the iteration w/ the filter in AIX.cpp around line 475, but it may be the iteration in `buildExceptionList`.

Thanks, this should be fixed with https://github.com/llvm/llvm-project/pull/86840

https://github.com/llvm/llvm-project/pull/67999