[clang] [hwasan] Don't instrument when PGO profile is collected (PR #86739)

Vitaly Buka via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 14:18:34 PDT 2024


vitalybuka wrote:

> why can't hwasan and PGO instrumentation coexist?

They can, but binary is like 5x times slower, on top of 10x slowdown of PGO instrumentation.

> 
> and this seems like it should be an error at the clang driver level, instead of silently turning off one of the requested features

1. We need -fsanitizer=hwaddress, for attributes and profile matching, and some special handling done in earlier passes.
2. We don't wan't users care about profile instrumentation/use difference.

https://github.com/llvm/llvm-project/pull/86739


More information about the cfe-commits mailing list