[clang-tools-extra] [clang-tidy] add check to suggest replacement of nested std::min or std::max with initializer lists (PR #85572)

Piotr Zegar via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 26 12:37:27 PDT 2024


https://github.com/PiotrZSL commented:

Except already raised code-smells, i do not like `MinMaxUseInitializerListCheck::generateReplacement` method.
My main problem with it is that, once things like whitespaces, comments (between arguments) and other stuff will be used, this function may not always produce proper output. As for version 1.0 could be.


https://github.com/llvm/llvm-project/pull/85572


More information about the cfe-commits mailing list