[clang] [clang] Implement constexpr support for __builtin_{clzg, ctzg} (PR #86577)

Nick Desaulniers via cfe-commits cfe-commits at lists.llvm.org
Mon Mar 25 14:27:41 PDT 2024


================
@@ -12367,8 +12368,17 @@ bool IntExprEvaluator::VisitBuiltinCallExpr(const CallExpr *E,
                            BuiltinOp != Builtin::BI__lzcnt &&
                            BuiltinOp != Builtin::BI__lzcnt64;
 
-    if (ZeroIsUndefined && !Val)
-      return Error(E);
+    if (!Val) {
----------------
nickdesaulniers wrote:

Hmm...for these 2 type generic builtins, it might be nice to check the number of arguments first, then call `EvaluateInteger` on the correct arg, rather than calling `EvaluateInteger`, failing, then calling `EvaluateInteger` again on the second arg.

https://github.com/llvm/llvm-project/pull/86577


More information about the cfe-commits mailing list