[clang-tools-extra] [clang-tidy] Fix result check after overwriteChangedFiles() (PR #86360)
Mike Rice via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 22 16:38:34 PDT 2024
https://github.com/mikerice1969 created https://github.com/llvm/llvm-project/pull/86360
If any return from overwriteChangedFiles is true some fixes were not applied.
>From 492e0fc4e146d7321003470a9cd0b4be4ae39d7a Mon Sep 17 00:00:00 2001
From: Mike Rice <michael.p.rice at intel.com>
Date: Fri, 22 Mar 2024 16:02:54 -0700
Subject: [PATCH] [clang-tidy] Fix result check after overwriteChangedFiles()
If any return from overwriteChangedFiles is true some fixes were not
applied.
---
clang-tools-extra/clang-tidy/ClangTidy.cpp | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/clang-tools-extra/clang-tidy/ClangTidy.cpp b/clang-tools-extra/clang-tidy/ClangTidy.cpp
index 40ac6918faf407..b877ea06dc05cd 100644
--- a/clang-tools-extra/clang-tidy/ClangTidy.cpp
+++ b/clang-tools-extra/clang-tidy/ClangTidy.cpp
@@ -233,7 +233,7 @@ class ErrorReporter {
if (!tooling::applyAllReplacements(Replacements.get(), Rewrite)) {
llvm::errs() << "Can't apply replacements for file " << File << "\n";
}
- AnyNotWritten &= Rewrite.overwriteChangedFiles();
+ AnyNotWritten |= Rewrite.overwriteChangedFiles();
}
if (AnyNotWritten) {
More information about the cfe-commits
mailing list