[clang] AMDGPU: Rename and add bf16 support for global_load_tr builtins (PR #86202)

Shilei Tian via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 21 17:26:51 PDT 2024


shiltian wrote:

> > > > Do you want to rename intrinsics as well? Because now intrinsic names do not match builtin names.
> > > 
> > > 
> > > Do we have to match builtins with intrinsics? Renaming intrinsics here means we will have to duplicate the intrinsics.
> > 
> > 
> > Is that because of the mangling?
> > Right.  It was originally suggested to use  a single instrinsic "load_lr".  But eventually we use global_load_tr to indicate this is in global address space.  If we want to rename intrinsics here, it should be global_load_tr_b64 and global_load_tr_b128.
> 
> We should rename intrinsic if users can use intrinsics directly. I think use-friendly is more important.

I don't think intrinsics are meant for users. Builtins are the user-facing front. :-)

https://github.com/llvm/llvm-project/pull/86202


More information about the cfe-commits mailing list