[clang] [clang-tools-extra] [libcxx] [clang] Enable sized deallocation by default in C++14 onwards (PR #83774)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Wed Mar 20 06:11:18 PDT 2024


AaronBallman wrote:

> > Did you explicitly list ??3 at YAXPEAX_K@Z as it was not part of that code?
> 
> It is part of that code: https://github.com/llvm/llvm-project/pull/84769/files#diff-d7f5dca2bd540f1b18ba90a66497b6b12e40fd07058b70f0fdec638c8e97406eR35

@vgvassilev and I chatted off-list about this and we eventually got to the bottom of it. You need to add the CMake changes linked above into the CMakeLists.txt that's picked up for unit and lit tests. I think that means adding the changes to libclangInterpreter, but I got the unit tests working by adding the changes to `clang/unitests/Interpreter/CMakeLists.txt`. One thing to pay attention to is the target you're setting the properties for (e.g., you don't want to use `clang-repl` as the target because unit tests won't pick that up, I had to use `ClangReplInterpreterTests` to get the unit tests to pass).

https://github.com/llvm/llvm-project/pull/83774


More information about the cfe-commits mailing list