[clang] [llvm] [DXIL] implement dot intrinsic lowering for integers (PR #85662)

Farzon Lotfi via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 19 10:47:47 PDT 2024


farzonl wrote:

> Hi @farzonl, your commit is causing at least one test failure on a build bot: https://lab.llvm.org/buildbot/#/builders/139/builds/61732
> 
> ```
> ******************** TEST 'Clang :: SemaHLSL/BuiltIns/dot-errors.hlsl' FAILED ********************
> Exit Code: 1
> Command Output (stderr):
> --
> RUN: at line 1: /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/19/include -nostdsysteminc -finclude-default-header -triple dxil-pc-shadermodel6.6-library /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaHLSL/BuiltIns/dot-errors.hlsl -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected
> + /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/bin/clang -cc1 -internal-isystem /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/build/lib/clang/19/include -nostdsysteminc -finclude-default-header -triple dxil-pc-shadermodel6.6-library /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaHLSL/BuiltIns/dot-errors.hlsl -fnative-half-type -emit-llvm -disable-llvm-passes -verify -verify-ignore-unexpected
> error: 'expected-error' diagnostics expected but not seen: 
>   File /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaHLSL/BuiltIns/dot-errors.hlsl Line 117 (directive at /home/buildbot/buildbot-root/llvm-clang-x86_64-sie-ubuntu-fast/llvm-project/clang/test/SemaHLSL/BuiltIns/dot-errors.hlsl:118): passing 'double2' (aka 'vector<double, 2>') to parameter of incompatible type '__attribute__((__vector_size__(2 * sizeof(float)))) float' (vector of 2 'float' values)
> 1 error generated.
> --
> ********************
> ```
> 
> Other failing buildbots include:
> 
> * https://lab.llvm.org/buildbot/#/builders/216/builds/36204
> * https://lab.llvm.org/buildbot/#/builders/247/builds/15516
> * https://lab.llvm.org/buildbot/#/builders/280/builds/469
> 
> Can you take a look and revert if you need time to investigate?

This is my own test case failing.  
need:  essentially this as a return but thats gettign complicated.`BaseType->isFloatingType() && !BaseType->isHalfType() && !BaseType->isFloat32Type();`

But it would be simpler to just have a double check  so im going to do something like this ` return VecTy->getElementType()->isDoubleType();`

https://github.com/llvm/llvm-project/pull/85662


More information about the cfe-commits mailing list