[clang] [Clang] Ignore assumptions with side effects at compile time (PR #85534)

[via cfe-commits]

Sirraide wrote:

> I think this is also https://eel.is/c++draft/expr.const#6.4, the note is a bit more clear than the standard wording.

That’s also a good point; I sort of forgot about that one. 

Either way, I’ll wait for a review next time seeing as this was perhaps not that ‘obvious’ of a change as I had originally thought.

https://github.com/llvm/llvm-project/pull/85534