[clang] [NVPTX] Add `-march=general` option to mirror default configuration (PR #85222)
Joseph Huber via cfe-commits
cfe-commits at lists.llvm.org
Fri Mar 15 07:13:25 PDT 2024
================
@@ -750,10 +750,11 @@ NVPTXToolChain::TranslateArgs(const llvm::opt::DerivedArgList &Args,
if (!llvm::is_contained(*DAL, A))
DAL->append(A);
- // TODO: We should accept 'generic' as a valid architecture.
if (!DAL->hasArg(options::OPT_march_EQ) && OffloadKind != Action::OFK_None) {
DAL->AddJoinedArg(nullptr, Opts.getOption(options::OPT_march_EQ),
CudaArchToString(CudaArch::CudaDefault));
+ } else if (DAL->getLastArgValue(options::OPT_march_EQ) == "generic") {
----------------
jhuber6 wrote:
```suggestion
} else if (DAL->getLastArgValue(options::OPT_march_EQ) == "generic"
&& OffloadKind == Action::OFK_None) {
```
Ah, forgot, we probably don't want to expose this to CUDA just yet.
https://github.com/llvm/llvm-project/pull/85222
More information about the cfe-commits
mailing list