[clang] [llvm] [analyzer] Accept C library functions from the `std` namespace (PR #84469)

[Balazs Benics via cfe-commits]

=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,
=?utf-8?q?Donát?= Nagy <donat.nagy at ericsson.com>,Balazs Benics
 <benicsbalazs at gmail.com>,NagyDonat <donat.nagy at ericsson.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/84469 at github.com>


steakhal wrote:

Thanks!
Indeed, it looks like valgrind also complains:
```
[ RUN      ] IsCLibraryFunctionTest.AcceptsGlobal
==999215== Invalid read of size 1
==999215==    at 0x15420D0: hasAttrs (DeclBase.h:523)
==999215==    by 0x15420D0: getAttr<clang::ArmBuiltinAliasAttr> (DeclBase.h:579)
==999215==    by 0x15420D0: clang::FunctionDecl::getBuiltinID(bool) const (???:3597)
==999215==    by 0x1D20BE0: clang::ento::CheckerContext::isCLibraryFunction(clang::FunctionDecl const*, llvm::StringRef) (../../clang/lib/StaticAnalyzer/Core/CheckerContext.cpp:54)
==999215==    by 0x117DACC: IsCLibraryFunctionTest_AcceptsGlobal_Test::TestBody() (../../clang/unittests/StaticAnalyzer/IsCLibraryFunctionTest.cpp:40)
==999215==    by 0x12D9778: HandleExceptionsInMethodIfSupported<testing::Test, void> (gtest.cc:0)
==999215==    by 0x12D9778: testing::Test::Run() (gtest.cc:2687)
==999215==    by 0x12DAB6D: testing::TestInfo::Run() (gtest.cc:2836)
==999215==    by 0x12DBE84: testing::TestSuite::Run() (gtest.cc:3015)
==999215==    by 0x12EAA3D: testing::internal::UnitTestImpl::RunAllTests() (gtest.cc:5920)
==999215==    by 0x12E9E6E: HandleExceptionsInMethodIfSupported<testing::internal::UnitTestImpl, bool> (gtest.cc:0)
==999215==    by 0x12E9E6E: testing::UnitTest::Run() (gtest.cc:5484)
==999215==    by 0x12C71EC: RUN_ALL_TESTS (gtest.h:2317)
==999215==    by 0x12C71EC: main (???:55)
```
I'll look into this.

https://github.com/llvm/llvm-project/pull/84469