[clang] [clang][Interp] Merge ByteCodeExprGen and ByteCodeStmtGen (PR #83683)

Aaron Ballman via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 12 07:18:59 PDT 2024


Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>,
Timm =?utf-8?q?Bäder?= <tbaeder at redhat.com>
Message-ID:
In-Reply-To: <llvm.org/llvm/llvm-project/pull/83683 at github.com>


AaronBallman wrote:

> Ping

Sorry, I thought you were still doing some investigation.

I can live with either approach; the CRTP way doesn't seem too awful to me and retains the separation. But the unified interface also doesn't seem too awful to me given the relationship between `Stmt` and `Expr` in our AST. Given your preference for the unified interface, I'd be okay moving forward with that.

Any other opinions @erichkeane @cor3ntin @shafik ?

https://github.com/llvm/llvm-project/pull/83683


More information about the cfe-commits mailing list