[clang] f03aaa3 - [clang] Silence -Wlogical-op-parentheses in Clang.cpp (NFC)

Jie Fu via cfe-commits cfe-commits at lists.llvm.org
Tue Mar 12 06:25:36 PDT 2024


Author: Jie Fu
Date: 2024-03-12T21:24:37+08:00
New Revision: f03aaa3c0cca77c15adfbb4544f296bc0441f6fc

URL: https://github.com/llvm/llvm-project/commit/f03aaa3c0cca77c15adfbb4544f296bc0441f6fc
DIFF: https://github.com/llvm/llvm-project/commit/f03aaa3c0cca77c15adfbb4544f296bc0441f6fc.diff

LOG: [clang] Silence -Wlogical-op-parentheses in Clang.cpp (NFC)

llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:2721:49:
error: '&&' within '||' [-Werror,-Wlogical-op-parentheses]
        !Option.empty() && !NegateFortranOption && !NegateLimitedOption)
        ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~
llvm-project/clang/lib/Driver/ToolChains/Clang.cpp:2721:49:
note: place parentheses around the '&&' expression to silence this warning
        !Option.empty() && !NegateFortranOption && !NegateLimitedOption)
                                                ^
        (                                                              )
1 error generated.

Added: 
    

Modified: 
    clang/lib/Driver/ToolChains/Clang.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/Driver/ToolChains/Clang.cpp b/clang/lib/Driver/ToolChains/Clang.cpp
index 6246a28a13060e..3a7a1cf99c79ac 100644
--- a/clang/lib/Driver/ToolChains/Clang.cpp
+++ b/clang/lib/Driver/ToolChains/Clang.cpp
@@ -2718,7 +2718,7 @@ static void EmitComplexRangeDiag(const Driver &D,
           Option == "-fno-cx-limited-range";
     }
     if (Option.empty() ||
-        !Option.empty() && !NegateFortranOption && !NegateLimitedOption)
+        (!Option.empty() && !NegateFortranOption && !NegateLimitedOption))
       D.Diag(clang::diag::warn_drv_overriding_option)
           << EnumComplexRangeToStr(Range1, Option)
           << EnumComplexRangeToStr(Range2, Option);


        


More information about the cfe-commits mailing list