[clang] 630289f - [HIP] Do not include the CUID module hash with the new driver (#84332)

via cfe-commits cfe-commits at lists.llvm.org
Thu Mar 7 09:04:44 PST 2024


Author: Joseph Huber
Date: 2024-03-07T11:04:40-06:00
New Revision: 630289f77d67703673928ae38d3e5ba900e9ff62

URL: https://github.com/llvm/llvm-project/commit/630289f77d67703673928ae38d3e5ba900e9ff62
DIFF: https://github.com/llvm/llvm-project/commit/630289f77d67703673928ae38d3e5ba900e9ff62.diff

LOG: [HIP] Do not include the CUID module hash with the new driver (#84332)

Summary:
The new driver does not need this hash and it can lead to redefined
symbol errors when the CUID hash isn't set.

Added: 
    

Modified: 
    clang/lib/CodeGen/CodeGenModule.cpp

Removed: 
    


################################################################################
diff  --git a/clang/lib/CodeGen/CodeGenModule.cpp b/clang/lib/CodeGen/CodeGenModule.cpp
index d02875c6a86d77..967319bdfc4571 100644
--- a/clang/lib/CodeGen/CodeGenModule.cpp
+++ b/clang/lib/CodeGen/CodeGenModule.cpp
@@ -916,7 +916,7 @@ void CodeGenModule::Release() {
         llvm::ConstantArray::get(ATy, UsedArray), "__clang_gpu_used_external");
     addCompilerUsedGlobal(GV);
   }
-  if (LangOpts.HIP) {
+  if (LangOpts.HIP && !getLangOpts().OffloadingNewDriver) {
     // Emit a unique ID so that host and device binaries from the same
     // compilation unit can be associated.
     auto *GV = new llvm::GlobalVariable(


        


More information about the cfe-commits mailing list